Skip to content

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma commented Sep 19, 2022

Related to #4077

Preview:
image

@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner September 19, 2022 19:08
@BrunoQuaresma BrunoQuaresma self-assigned this Sep 19, 2022
@BrunoQuaresma BrunoQuaresma requested review from jsjoeio and removed request for a team September 19, 2022 19:08

- `resource_type` - The type of the resource. It can be a workspace, template, user, etc. You can [find here](https://pkg.go.dev/github.com/coder/coder@main/codersdk#ResourceType) all the resource types that are supported.
- `action`- The action applied to a resource. You can [find here](https://pkg.go.dev/github.com/coder/coder@main/codersdk#AuditAction) all the actions that are supported.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bpmct I would appreciate your help with this doc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well for now! Sorry I missed it

@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) September 19, 2022 19:54
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!


await waitForLoaderToBeRemoved()

expect(getAuditLogsSpy).toBeCalledWith({ limit: 25, offset: 0, q: query })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice tests 👏🏼

@BrunoQuaresma BrunoQuaresma merged commit 1186e64 into main Sep 20, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/add-audit-filter branch September 20, 2022 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy