refactor: Add group badge to diff groups from users #4478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kira-Pilot
reviewed
Oct 11, 2022
| height: 14, | ||
| }, | ||
| }, | ||
| }))(Badge) |
There was a problem hiding this comment.
What does (Badge) do here? Is that applying the styles for Badge as well?
There was a problem hiding this comment.
Yes, it is a better way, IMO, to modify component styles. So what it does is extend the Badge component with the new styles.
Kira-Pilot
reviewed
Oct 11, 2022
Kira-Pilot
reviewed
Oct 11, 2022
Co-authored-by: Kira Pilot <kira@coder.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4459
Before:
After:
