chore: Support anonymously embedded fields for audit diffs #5746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Unit tests for anonymously embedded structs - Add docs and refactor code around
|
@coadler What do you think about expanding anonymous fields like this? I intentionally am avoiding using named nested structs, since that adds hierarchy complexity. Anonymous fields being expanded like this adds some convenience for the other PR linked in the description. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds support for anonymously embedded structs in audit diffs. Named nested structs are still not supported.
Anonymous structs can reasonably be recursively flattened to the top level struct. This is to support #5730.
The example type in question. It is easiest to anonymously embed the Group type that is auto generated with Sqlc. The
Grouptype's fields should be treated as top level fields.