chore: update to go 1.20 #5968
Merged
chore: update to go 1.20 #5968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4097.
coadler
approved these changes
Feb 1, 2023
mafredri
reviewed
Feb 2, 2023
dogfood/Dockerfile
Outdated
| @@ -210,7 +210,7 @@ RUN systemctl enable \ | |||
| ARG CLOUD_SQL_PROXY_VERSION=1.26.0 \ | |||
| DIVE_VERSION=0.10.0 \ | |||
| DOCKER_GCR_VERSION=2.1.0 \ | |||
| GOLANGCI_LINT_VERSION=1.48.0 \ | |||
| GOLANGCI_LINT_VERSION=1.50.1 \ | |||
There was a problem hiding this comment.
When I was using the go 1.20rc, golangci-lint v1.50.1 lead to massive memory consumption. I noticed CI failed, this could be the reason (OOM killed).
There was a problem hiding this comment.
Seems this might be fixed in v1.51.0, if we switch to that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4097.