Skip to content

fix: use error log when failing provisioner job #6812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 5, 2023
Merged

fix: use error log when failing provisioner job #6812

merged 3 commits into from
Apr 5, 2023

Conversation

ElliotG
Copy link
Contributor

@ElliotG ElliotG commented Mar 27, 2023

Thoughts on making this an error message?

@ElliotG ElliotG requested a review from kylecarbs March 27, 2023 15:42
kylecarbs
kylecarbs approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine!

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Apr 5, 2023
@coadler coadler changed the title Change from Warning to Error fix: use error log when failing provisioner job Apr 5, 2023
@coadler coadler removed the stale This issue is like stale bread. label Apr 5, 2023
@coadler coadler merged commit 0069831 into main Apr 5, 2023
@coadler coadler deleted the eg/error branch April 5, 2023 18:30
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@ElliotG ElliotG

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ElliotG @kylecarbs @coadler
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy