Skip to content

feat(site): Display workspace build error + option to retry in debug mode #6903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 31, 2023
Merged

feat(site): Display workspace build error + option to retry in debug mode #6903

merged 10 commits into from
Mar 31, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma commented Mar 30, 2023 •
edited
Loading

The demo got too big, so here is a link for the video on Drive: https://drive.google.com/file/d/1mGuLNlGu-SWF9dGqdO8AbYUyhKky0DT6/view?usp=sharing

Closes #4767

@BrunoQuaresma BrunoQuaresma requested review from mtojek, a team and Kira-Pilot and removed request for a team March 30, 2023 19:46
@ghuntley
Copy link
Contributor

Similar to above #6889

@BrunoQuaresma
Copy link
Collaborator Author

@ghuntley nice! Let me check.

mtojek
mtojek reviewed Mar 31, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things on my side:

  • validating user permissions
  • violating open-closed principle (log_level vs. debugMode)

@BrunoQuaresma BrunoQuaresma requested a review from mtojek March 31, 2023 13:31
mtojek
mtojek approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I played with this locally, and it works fine 👍 Thank you!

@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) March 31, 2023 13:38
Kira-Pilot
Kira-Pilot reviewed Mar 31, 2023
View reviewed changes
Kira-Pilot
Kira-Pilot reviewed Mar 31, 2023
View reviewed changes
Kira-Pilot
Kira-Pilot approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@BrunoQuaresma BrunoQuaresma merged commit 90e2bab into main Mar 31, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/display-build-error branch March 31, 2023 14:01
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek approved these changes

@Kira-Pilot Kira-Pilot Kira-Pilot approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubernetes builds are difficult to debug
4 participants
@BrunoQuaresma @ghuntley @mtojek @Kira-Pilot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy