Skip to content

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Apr 1, 2022

The latter is deprecated: https://pkg.go.dev/golang.org/x/crypto/ssh/terminal

The deprecated packages linter doesn't seem to be working in 1.18 😞

@coadler coadler requested a review from kylecarbs April 1, 2022 21:17
@coadler coadler self-assigned this Apr 1, 2022
@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #837 (332304a) into main (fd52310) will decrease coverage by 0.36%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #837      +/-   ##
==========================================
- Coverage   66.13%   65.76%   -0.37%     
==========================================
  Files         200      196       -4     
  Lines       13179    12993     -186     
  Branches       87       87              
==========================================
- Hits         8716     8545     -171     
+ Misses       3582     3573       -9     
+ Partials      881      875       -6     
Flag Coverage Δ
unittest-go- 65.39% <0.00%> (-0.20%) ⬇️
unittest-go-macos-latest ?
unittest-go-ubuntu-latest 55.01% <0.00%> (-0.22%) ⬇️
unittest-go-windows-2022 ?
unittest-js 62.63% <ø> (ø)
Impacted Files Coverage Δ
cli/ssh.go 39.84% <0.00%> (ø)
cli/configssh.go 50.00% <0.00%> (-8.04%) ⬇️
provisionersdk/transport.go 78.72% <0.00%> (-6.39%) ⬇️
codersdk/provisionerdaemons.go 58.46% <0.00%> (-6.16%) ⬇️
pty/ptytest/ptytest.go 89.65% <0.00%> (-5.18%) ⬇️
cli/projectinit.go 56.36% <0.00%> (-3.64%) ⬇️
provisioner/echo/serve.go 54.40% <0.00%> (-2.40%) ⬇️
peer/conn.go 78.93% <0.00%> (-2.29%) ⬇️
provisionerd/provisionerd.go 79.58% <0.00%> (-2.06%) ⬇️
peer/channel.go 83.04% <0.00%> (-0.59%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd52310...332304a. Read the comment docs.

Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice nice

@coadler coadler enabled auto-merge (squash) April 1, 2022 21:25
@coadler coadler merged commit 2a7ab08 into main Apr 1, 2022
@coadler coadler deleted the colin/x-term branch April 1, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy