Skip to content

feat(helm)!: set enableDeployments default to true #8704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2023
Merged

feat(helm)!: set enableDeployments default to true #8704

merged 1 commit into from
Jul 24, 2023

Conversation

ericpaulsen
Copy link
Member

@ericpaulsen ericpaulsen commented Jul 24, 2023 •
edited
Loading

as we move toward rolling out logstream-kube solution, setting enableDeployments: true as the default will remove a step for customers who are looking to migrate workspace to Deployments.

NOTE: this is a breaking change in our Helm chart.

@ericpaulsen ericpaulsen requested a review from bpmct July 24, 2023 20:39
@ericpaulsen ericpaulsen self-assigned this Jul 24, 2023
@ericpaulsen ericpaulsen changed the title helm: set enableDeployments default to true feat(helm): set enableDeployments default to true Jul 24, 2023
@bpmct bpmct added the release/breaking This label is applied to PRs to detect breaking changes as part of the release process label Jul 24, 2023
@github-actions github-actions bot changed the title feat(helm): set enableDeployments default to true feat(helm)!: set enableDeployments default to true Jul 24, 2023
@bpmct bpmct merged commit 2996343 into main Jul 24, 2023
@bpmct bpmct deleted the deployment-rbac-default branch July 24, 2023 22:13
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpmct bpmct bpmct approved these changes

Assignees

@ericpaulsen ericpaulsen

Labels
release/breaking This label is applied to PRs to detect breaking changes as part of the release process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericpaulsen @bpmct
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy