Skip to content

Conversation

kylecarbs
Copy link
Member

It was occasionally failing without any clear indication of
what to fix on our side. The plugins weren't being found
by Terraform.

We already disable this on Windows, so figured it's fine on
Darwin too considering most production deployments will be Linux.

@kylecarbs kylecarbs requested a review from deansheather April 8, 2022 15:39
@kylecarbs kylecarbs self-assigned this Apr 8, 2022
It was occasionally failing without any clear indication of
what to fix on our side. The plugins weren't being found
by Terraform.

We already disable this on Windows, so figured it's fine on
Darwin too considering most production deployments will be Linux.
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #927 (2f259e1) into main (94ab6f3) will decrease coverage by 0.18%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #927      +/-   ##
==========================================
- Coverage   65.75%   65.56%   -0.19%     
==========================================
  Files         226      226              
  Lines       13998    13998              
  Branches      105      105              
==========================================
- Hits         9204     9178      -26     
- Misses       3854     3873      +19     
- Partials      940      947       +7     
Flag Coverage Δ
unittest-go-macos-latest 52.88% <0.00%> (-0.05%) ⬇️
unittest-go-postgres- 65.53% <0.00%> (+0.03%) ⬆️
unittest-go-ubuntu-latest 55.39% <0.00%> (-0.06%) ⬇️
unittest-go-windows-2022 52.21% <0.00%> (-0.05%) ⬇️
unittest-js 58.25% <ø> (ø)
Impacted Files Coverage Δ
provisioner/terraform/provision.go 68.82% <0.00%> (ø)
peerbroker/dial.go 77.04% <0.00%> (-6.56%) ⬇️
coderd/workspaceresources.go 54.87% <0.00%> (-4.48%) ⬇️
peer/conn.go 78.42% <0.00%> (-3.56%) ⬇️
provisioner/echo/serve.go 54.40% <0.00%> (-2.40%) ⬇️
coderd/provisionerdaemons.go 62.56% <0.00%> (+0.50%) ⬆️
provisionersdk/transport.go 85.10% <0.00%> (+6.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94ab6f3...2f259e1. Read the comment docs.

@kylecarbs kylecarbs merged commit 35a0acc into main Apr 8, 2022
@kylecarbs kylecarbs deleted the provisioncache branch April 8, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy