PR review + fmt

ibetitsmike · ibetitsmike · commit 9037758ade15 · 2025-06-02T18:57:39.000+02:00
diff --git a/App/Services/SettingsManager.cs b/App/Services/SettingsManager.cs
@@ -82,7 +82,7 @@ public SettingsManager(string? settingsFilePath = null)
         Directory.CreateDirectory(folder);
         _settingsFilePath = Path.Combine(folder, _fileName);
 
-        if(!File.Exists(_settingsFilePath))
+        if (!File.Exists(_settingsFilePath))
         {
             // Create the settings file if it doesn't exist
             string emptyJson = JsonSerializer.Serialize(new { });
diff --git a/App/ViewModels/SettingsViewModel.cs b/App/ViewModels/SettingsViewModel.cs
@@ -35,44 +35,46 @@ public SettingsViewModel(ILogger<SettingsViewModel> logger, ISettingsManager set
         // We disable the option in the UI if the policy is set.
         StartOnLoginDisabled = _startupManager.IsDisabledByPolicy();
 
-        this.PropertyChanged += (_, args) =>
+        // Ensure the StartOnLogin property matches the current startup state.
+        if (StartOnLogin != _startupManager.IsEnabled())
+        {
+            StartOnLogin = _startupManager.IsEnabled();
+        }
+    }
+
+    partial void OnConnectOnLaunchChanged(bool oldValue, bool newValue)
+    {
+        if (oldValue == newValue)
+            return;
+        try
+        {
+            _settingsManager.ConnectOnLaunch = ConnectOnLaunch;
+        }
+        catch (Exception ex)
         {
-            if (args.PropertyName == nameof(ConnectOnLaunch))
+            _logger.LogError($"Error saving {SettingsManager.ConnectOnLaunchKey} setting: {ex.Message}");
+        }
+    }
+
+    partial void OnStartOnLoginChanged(bool oldValue, bool newValue)
+    {
+        if (oldValue == newValue)
+            return;
+        try
+        {
+            _settingsManager.StartOnLogin = StartOnLogin;
+            if (StartOnLogin)
             {
-                try
-                {
-                    _settingsManager.ConnectOnLaunch = ConnectOnLaunch;
-                }
-                catch (Exception ex)
-                {
-                    _logger.LogError($"Error saving {SettingsManager.ConnectOnLaunchKey} setting: {ex.Message}");
-                }
+                _startupManager.Enable();
             }
-            else if (args.PropertyName == nameof(StartOnLogin))
+            else
             {
-                try
-                {
-                    _settingsManager.StartOnLogin = StartOnLogin;
-                    if (StartOnLogin)
-                    {
-                        _startupManager.Enable();
-                    }
-                    else
-                    {
-                        _startupManager.Disable();
-                    }
-                }
-                catch (Exception ex)
-                {
-                    _logger.LogError($"Error saving {SettingsManager.StartOnLoginKey} setting: {ex.Message}");
-                }
+                _startupManager.Disable();
             }
-        };
-
-        // Ensure the StartOnLogin property matches the current startup state.
-        if (StartOnLogin != _startupManager.IsEnabled())
+        }
+        catch (Exception ex)
         {
-            StartOnLogin = _startupManager.IsEnabled();
+            _logger.LogError($"Error saving {SettingsManager.StartOnLoginKey} setting: {ex.Message}");
         }
     }
 }
diff --git a/App/Views/Pages/SettingsMainPage.xaml.cs b/App/Views/Pages/SettingsMainPage.xaml.cs
@@ -9,7 +9,7 @@ public sealed partial class SettingsMainPage : Page
 
     public SettingsMainPage(SettingsViewModel viewModel)
     {
-        ViewModel = viewModel; // already initialized
+        ViewModel = viewModel;
         InitializeComponent();
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ public SettingsManager(string? settingsFilePath = null)`
`82`	`82`	`Directory.CreateDirectory(folder);`
`83`	`83`	`_settingsFilePath = Path.Combine(folder, _fileName);`
`84`	`84`
`85`		`- if(!File.Exists(_settingsFilePath))`
	`85`	`+ if (!File.Exists(_settingsFilePath))`
`86`	`86`	`{`
`87`	`87`	`// Create the settings file if it doesn't exist`
`88`	`88`	`string emptyJson = JsonSerializer.Serialize(new { });`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ public sealed partial class SettingsMainPage : Page`
`9`	`9`
`10`	`10`	`public SettingsMainPage(SettingsViewModel viewModel)`
`11`	`11`	`{`
`12`		`- ViewModel = viewModel; // already initialized`
	`12`	`+ ViewModel = viewModel;`
`13`	`13`	`InitializeComponent();`
`14`	`14`	`}`
`15`	`15`	`}`