Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

chore: cleanup error output for "coder sh" #214

Merged
merged 2 commits into from
Jan 13, 2021
Merged

chore: cleanup error output for "coder sh" #214

merged 2 commits into from
Jan 13, 2021

Conversation

cmoog
Copy link
Contributor

@cmoog cmoog commented Jan 12, 2021

Closes #213

$ coder sh
error: missing [environment_name] argument
  | specify one of ["test7" "test6" "test3" "test1"]
  | 
  | tip: run "coder envs ls" to view your environments

exit status 1
$ coder sh fakename
fatal: failed to find environment
  | environment "fakename" not found in ["test7" "test6" "test3" "test1"]
  | 
  | tip: run "coder envs ls" to view your environments

exit status 1

I'm considering adding special handling for --help and -h.

@cmoog cmoog marked this pull request as ready for review January 13, 2021 16:10
@cmoog cmoog requested a review from fuskovic January 13, 2021 16:10
fuskovic
fuskovic approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@fuskovic fuskovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haystack ftw!

@cmoog
Update internal/cmd/shell.go
957b9c4 
Co-authored-by: Faris Huskovic <faris@coder.com>
@cmoog cmoog merged commit e516b8c into master Jan 13, 2021
@cmoog cmoog deleted the cmoog/improve-err-msg branch January 13, 2021 17:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@fuskovic fuskovic fuskovic approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

provide better error message for coder sh
2 participants
@cmoog @fuskovic
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy