Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

chore: update template request field name from 'name' to 'file_name' #231

Merged
merged 1 commit into from
Jan 26, 2021
Merged

chore: update template request field name from 'name' to 'file_name' #231

merged 1 commit into from
Jan 26, 2021

Conversation

sreya
Copy link
Collaborator

@sreya sreya commented Jan 26, 2021

No description provided.

@sreya sreya requested a review from cmoog January 26, 2021 20:07
cmoog
cmoog approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@cmoog cmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is FilePath more appropriate?

@sreya
Copy link
Collaborator Author

sreya commented Jan 26, 2021

I think we're constraining files to the .coder directory, which we'll assume is in the root of the repo

@cmoog
Copy link
Contributor

cmoog commented Jan 26, 2021

Ahhh, makes sense... much better.

@sreya sreya merged commit 307ddd3 into master Jan 26, 2021
@sreya sreya deleted the update-wac-api branch January 26, 2021 20:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@cmoog cmoog cmoog approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sreya @cmoog
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy