This repository was archived by the owner on Aug 30, 2024. It is now read-only.
feat: Add Ping command to monitor workspace latency #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jawnsy
reviewed
Aug 9, 2021
internal/cmd/ping.go
Outdated
| return err | ||
| } | ||
|
|
||
| fmt.Printf("%.2fms (%s) seq=%d\n", |
There was a problem hiding this comment.
not needed for an MVP, of course, but would be nice if this printed stats when the user quit, like the actual ping command:
$ ping -c 3 google.com
PING google.com(sfo03s24-in-x0e.1e100.net (2607:f8b0:4005:80c::200e)) 56 data bytes
64 bytes from sfo03s24-in-x0e.1e100.net (2607:f8b0:4005:80c::200e): icmp_seq=1 ttl=118 time=10.8 ms
64 bytes from sfo03s24-in-x0e.1e100.net (2607:f8b0:4005:80c::200e): icmp_seq=2 ttl=118 time=10.3 ms
64 bytes from sfo03s24-in-x0e.1e100.net (2607:f8b0:4005:80c::200e): icmp_seq=3 ttl=118 time=11.2 ms
--- google.com ping statistics ---
3 packets transmitted, 3 received, 0% packet loss, time 2003ms
rtt min/avg/max/mdev = 10.329/10.785/11.239/0.371 ms
also, what happens if we lose a ping response? this seems to assume the ping packets always come back, but that seems difficult to guarantee in general on a lossy network?
There was a problem hiding this comment.
I believe the Ping func would return an error and we'd exit... I'll check.
There was a problem hiding this comment.
Fixed in the latest iteration. Just like ping, failures will display inline.
We don't have stats yet, but that can be added later on!
jawnsy
reviewed
Aug 9, 2021
jawnsy
approved these changes
Aug 9, 2021
jawnsy
reviewed
Aug 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ch13708]