coder · deansheather · Oct 6, 2021 · Sep 22, 2021 · Sep 24, 2021 · Sep 24, 2021
diff --git a/internal/cmd/configssh.go b/internal/cmd/configssh.go
@@ -160,7 +160,7 @@ func binPath() (string, error) {
 	// Bash and OpenSSH for Windows (used by Powershell and VS Code) to function
 	// correctly. Check if the current executable is in $PATH, and warn the user
 	// if it isn't.
-	if runtime.GOOS == "windows" {
+	if runtime.GOOS == goosWindows {
 		binName := filepath.Base(exePath)
 
 		// We use safeexec instead of os/exec because os/exec returns paths in
@@ -268,7 +268,7 @@ func makeSSHConfig(binPath, workspaceName, privateKeyFilepath string, additional
 		fmt.Sprintf("IdentityFile=%q", privateKeyFilepath),
 	)
 
-	if runtime.GOOS == "linux" || runtime.GOOS == "darwin" {
+	if runtime.GOOS == goosLinux || runtime.GOOS == goosDarwin {
 		options = append(options,
 			"ControlMaster auto",
 			"ControlPath ~/.ssh/.connection-%r@%h:%p",

diff --git a/internal/cmd/login.go b/internal/cmd/login.go
@@ -4,7 +4,10 @@ import (
 	"bufio"
 	"context"
 	"fmt"
+	"io/ioutil"
 	"net/url"
+	"os/exec"
+	"runtime"
 	"strings"
 
 	"github.com/pkg/browser"
@@ -66,7 +69,8 @@ func login(cmd *cobra.Command, workspaceURL *url.URL) error {
 	q.Add("show_token", "true")
 	authURL.RawQuery = q.Encode()
 
-	if err := browser.OpenURL(authURL.String()); err != nil {
+	if err := openURL(authURL.String()); err != nil {
+		clog.LogWarn(err.Error())
 		fmt.Printf("Open the following in your browser:\n\n\t%s\n\n", authURL.String())
 	} else {
 		fmt.Printf("Your browser has been opened to visit:\n\n\t%s\n\n", authURL.String())
@@ -113,3 +117,36 @@ func pingAPI(ctx context.Context, workspaceURL *url.URL, token string) error {
 	}
 	return nil
 }
+
+// isWSL determines if coder-cli is running within Windows Subsystem for Linux
+func isWSL() (bool, error) {
+	if runtime.GOOS == goosDarwin || runtime.GOOS == goosWindows {
+		return false, nil
+	}
+	data, err := ioutil.ReadFile("/proc/version")
+	if err != nil {
+		return false, xerrors.Errorf("read /proc/version: %w", err)
+	}
+	return strings.Contains(strings.ToLower(string(data)), "microsoft"), nil
+}
+
+// openURL opens the provided URL via user's default browser
+func openURL(url string) error {
+	var cmd string
+	var args []string
+
+	wsl, err := isWSL()
+	if err != nil {
+		return xerrors.Errorf("test running Windows Subsystem for Linux: %w", err)
+	}
+
+	if wsl {
+		cmd = "cmd.exe"
+		args = []string{"/c", "start"}
+		url = strings.ReplaceAll(url, "&", "^&")
+		args = append(args, url)
+		return exec.Command(cmd, args...).Start()
+	}
+
+	return browser.OpenURL(url)
+}
diff --git a/internal/cmd/update.go b/internal/cmd/update.go
@@ -36,6 +36,7 @@ import (
 const (
 	goosWindows       = "windows"
 	goosLinux         = "linux"
+	goosDarwin        = "darwin"
 	apiPrivateVersion = "/api/private/version"
 )
 
@@ -181,7 +182,7 @@ func (u *updater) Run(ctx context.Context, force bool, coderURLArg string, versi
 	// TODO: validate the checksum of the downloaded file. GitHub does not currently provide this information
 	// and we do not generate them yet.
 	var updatedBinaryName string
-	if u.osF() == "windows" {
+	if u.osF() == goosWindows {
 		updatedBinaryName = "coder.exe"
 	} else {
 		updatedBinaryName = "coder"