Skip to content

Conversation

matifali
Copy link
Member

Closes coder/modules#162

When the terraform plan is run, the data.coder_workspace.me.owner_email and data.coder_workspace.me.owner_name fields are blank, which causes the template build to fail.

This should resolve the issue by setting those entries to a non-empty string.

Closes coder/modules#162

When the terraform plan is run, the `data.coder_workspace.me.owner_email` and `data.coder_workspace.me.owner_name` fields are blank, which causes the template build to fail. 

This should resolve the issue by setting those entries to a non-empty string.
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a unit test to validate this behaviour, and we should probably also validate that this only happens during the plan phase; if these values are unset at the apply stage then this is a pretty big bug somewhere in the coder <-> provider interface.

@matifali
Copy link
Member Author

We should add a unit test to validate this behaviour, and we should probably also validate that this only happens during the plan phase; if these values are unset at the apply stage, then this is a pretty big bug somewhere in the coder <-> provider interface.

I would be happy if someone could take this from here and add the tests. I opened this, considering its a smaller change. I am yet to feel confident about my Go skills.

@mtojek mtojek self-assigned this Apr 17, 2024
@mtojek mtojek requested a review from johnstcn April 23, 2024 14:34
@mtojek mtojek merged commit 8c5e8ff into main Apr 23, 2024
@mtojek mtojek deleted the matifali/set-default-owner branch April 23, 2024 14:40
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git config 1.0.3 Call to function "coalesce" failed: no non-null, non-empty-string arguments.
3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy