Skip to content

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Jul 12, 2024

An acceptance test is written, but commented out until we decide how we'll run it against a coderd instance.

Relates to #2

@deansheather deansheather requested a review from coadler July 12, 2024 10:50
@@ -0,0 +1,159 @@
// Copyright (c) HashiCorp, Inc.
// SPDX-License-Identifier: MPL-2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably remove this or change it to Coder

Copy link
Member Author

@ethanndickson ethanndickson Jul 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super confident in the language used by the MPL2:

3.4. Notices
You may not remove or alter the substance of any license notices
(including copyright notices, patent notices, disclaimers of warranty,
or limitations of liability) contained within the Source Code Form of
the Covered Software, except that You may alter any license notices to
the extent required to remedy known factual inaccuracies.

I would assume this only applies to files we use from the framework unchanged? i.e. This is in an example data source file, but we might not use the example files and therefore not have the notice.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna remove it from the files where it's all our code anyway

@ethanndickson ethanndickson merged commit 8416e35 into main Jul 15, 2024
1 of 6 checks passed
@ethanndickson ethanndickson deleted the ethan/user-data branch July 15, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy