Skip to content

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Aug 8, 2024

This bug would have been caught by the acceptance tests, had they not been run with the in-memory database.
Added a unit test for this very same edge case.

Also patches Coder to v2.14.1, and adds the correct group name default of the empty string, to be consistent with the web GUI.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ethanndickson and the rest of your teammates on Graphite Graphite

@ethanndickson ethanndickson marked this pull request as ready for review August 8, 2024 05:15
Copy link
Member Author

ethanndickson commented Aug 8, 2024

Merge activity

@ethanndickson ethanndickson merged commit cc7335a into main Aug 8, 2024
13 checks passed
@ethanndickson ethanndickson deleted the 08-08-fix_always_use_config_name_for_new_template_versions branch August 19, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy