Merge pull request confluentinc#263 from johnistan/fix-consumer-closed-tests

edenhill · web-flow · commit b89e63dc4c87 · 2017-10-11T12:47:53.000+02:00
Fix consumer close RuntimeError tests
diff --git a/tests/test_Consumer.py b/tests/test_Consumer.py
@@ -176,7 +176,7 @@ def test_multiple_close_throw_exception():
 
     with pytest.raises(RuntimeError) as ex:
         c.close()
-        assert 'Consumer already closed' == str(ex.value)
+    assert 'Consumer already closed' == str(ex.value)
 
 
 def test_any_method_after_close_throws_exception():
@@ -194,44 +194,60 @@ def test_any_method_after_close_throws_exception():
 
     with pytest.raises(RuntimeError) as ex:
         c.subscribe(['test'])
-        assert 'Consumer already closed' == str(ex.value)
+    assert 'Consumer closed' == str(ex.value)
 
     with pytest.raises(RuntimeError) as ex:
         c.unsubscribe()
-        assert 'Consumer already closed' == str(ex.value)
+    assert 'Consumer closed' == str(ex.value)
 
     with pytest.raises(RuntimeError) as ex:
         c.poll()
-        assert 'Consumer already closed' == str(ex.value)
+    assert 'Consumer closed' == str(ex.value)
 
     with pytest.raises(RuntimeError) as ex:
         c.assign([TopicPartition('test', 0)])
-        assert 'Consumer already closed' == str(ex.value)
+    assert 'Consumer closed' == str(ex.value)
 
     with pytest.raises(RuntimeError) as ex:
         c.unassign()
-        assert 'Consumer already closed' == str(ex.value)
+    assert 'Consumer closed' == str(ex.value)
 
     with pytest.raises(RuntimeError) as ex:
         c.assignment()
-        assert 'Consumer already closed' == str(ex.value)
-
-    with pytest.raises(RuntimeError) as ex:
-        c.store_offsets(offsets=[TopicPartition("test", 0, 42)])
-        assert 'Consumer already closed' == str(ex.value)
+    assert 'Consumer closed' == str(ex.value)
 
     with pytest.raises(RuntimeError) as ex:
         c.commit()
-        assert 'Consumer already closed' == str(ex.value)
+    assert 'Consumer closed' == str(ex.value)
 
     with pytest.raises(RuntimeError) as ex:
         c.committed([TopicPartition("test", 0)])
-        assert 'Consumer already closed' == str(ex.value)
+    assert 'Consumer closed' == str(ex.value)
 
     with pytest.raises(RuntimeError) as ex:
         c.position([TopicPartition("test", 0)])
-        assert 'Consumer already closed' == str(ex.value)
+    assert 'Consumer closed' == str(ex.value)
 
     with pytest.raises(RuntimeError) as ex:
         lo, hi = c.get_watermark_offsets(TopicPartition("test", 0))
-        assert 'Consumer already closed' == str(ex.value)
+    assert 'Consumer closed' == str(ex.value)
+
+
+@pytest.mark.skipif(libversion()[1] < 0x000b0000,
+                    reason="requires librdkafka >=0.11.0")
+def test_calling_store_offsets_after_close_throws_erro():
+    """ calling store_offset after close should throw RuntimeError """
+
+    c = Consumer({'group.id': 'test',
+                  'enable.auto.commit': True,
+                  'enable.auto.offset.store': False,
+                  'socket.timeout.ms': 50,
+                  'session.timeout.ms': 100})
+
+    c.subscribe(["test"])
+    c.unsubscribe()
+    c.close()
+
+    with pytest.raises(RuntimeError) as ex:
+        c.store_offsets(offsets=[TopicPartition("test", 0, 42)])
+    assert 'Consumer closed' == str(ex.value)
