Skip to content

Fix consumer close RuntimeError tests #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 11, 2017
Merged

Fix consumer close RuntimeError tests #263

merged 3 commits into from
Oct 11, 2017

Conversation

johnistan
Copy link
Contributor

My exception contents tests for #255 are noops. here are fixes.

@johnistan
Copy link
Contributor Author

Broken tests in first commit. Fix in second.

I am usually in love with pytest conventions, this one is a real foot gun.

@johnistan
Copy link
Contributor Author

already tracked here pytest-dev/pytest#2795

@johnistan johnistan changed the title Checks in failing tests Fix consumer close RuntimeError tests Oct 10, 2017
@edenhill edenhill merged commit b89e63d into confluentinc:master Oct 11, 2017
@edenhill
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnistan @edenhill
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy