fix(email): do not attempt to validate address #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex expression to correctly validate an email address is incredibly long and unnecessarily complex for what we are trying to accomplish here [1]. Instead of validating the email address, let's just make sure two values separated with an "@" are present. [1] https://en.wikipedia.org/wiki/Email_address#Syntax Signed-off-by: Randolph Sapp <rs@ti.com>
b1d03e3 to
1734c2d
Compare
|
shenxianpeng
approved these changes
Oct 28, 2024
|
Hi @StaticRocket, new versions commit-check-action@v1 and commit-check-action@v0.6.1 have been released. |
|
Awesome, thanks for the quick turnaround |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex expression to correctly validate an email address is incredibly long and unnecessarily complex for what we are trying to accomplish here [1]. Instead of validating the email address, let's just make sure two values separated with an "@" are present.
[1] https://en.wikipedia.org/wiki/Email_address#Syntax