Add forward compatibility layer for symfony/console >7.4 #12445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc624c1 to
d6e96f9
Compare
|
failing test looks flaky. unrelated |
|
Thanks |
| if (method_exists($app, 'addCommand')) { | ||
| $app->addCommand($cmd); | ||
| } else { | ||
| // Compatibility layer for symfony/console <7.4 |
There was a problem hiding this comment.
Suggestion: move the comment before the if block, since the whole block is actually the compatibility layer.
| @@ -372,7 +372,7 @@ private function doTestIntegration(string $file, string $message, ?string $condi | |||
|
|
|||
| return $installer->run(); | |||
| }); | |||
| $application->add($install); | |||
| method_exists($application, 'addCommand') ? $application->addCommand($install) : $application->add($install); | |||
There was a problem hiding this comment.
This line doesn't have a comment like the other ones.
| @@ -420,7 +420,7 @@ private function doTestIntegration(string $file, string $message, ?string $condi | |||
|
|
|||
| return $installer->run(); | |||
| }); | |||
| $application->add($update); | |||
| method_exists($application, 'addCommand') ? $application->addCommand($update) : $application->add($update); | |||
There was a problem hiding this comment.
This line doesn't have a comment like the other ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following symfony/symfony#60394. Please tell me if this should rather target main