-
Notifications
You must be signed in to change notification settings - Fork 919
Open
Labels
bugReporting an unexpected or problematic behavior of the codebaseReporting an unexpected or problematic behavior of the codebasepriority:highMaintainer triage tag for indicating high impact or criticality issuesMaintainer triage tag for indicating high impact or criticality issuesstatus:help-wantedIssues that would especially appreciate external development or attentionIssues that would especially appreciate external development or attention
Description
Description
(Changing a discussion to an issue, since it is fairly straightforward)
From python, calling a Consumer's commit function with parameters set to None (or other python False values) will resolve as boolean true in Consumer.c's checks, so instead of disregarding them, the function returns different errors.
How to reproduce
The issue can be seen when calling one of these:
consumer.commit(message=None)
consumer.commit(offsets=None)
consumer.commit(message=None, offsets=None)
But as a note:
kwargs = {'async': False }
consumer.commit(**kwargs)
and
consumer.commit(asynchronous=False)
work as expected.
Additionally
I suspect this is the line where it happens, but am not familiar:
https://github.com/confluentinc/confluent-kafka-python/blob/master/src/confluent_kafka/src/Consumer.c#L468C12-L468C12
Metadata
Metadata
Assignees
Labels
bugReporting an unexpected or problematic behavior of the codebaseReporting an unexpected or problematic behavior of the codebasepriority:highMaintainer triage tag for indicating high impact or criticality issuesMaintainer triage tag for indicating high impact or criticality issuesstatus:help-wantedIssues that would especially appreciate external development or attentionIssues that would especially appreciate external development or attention