fix test_message_serializer.py #1061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edenhill
suggested changes
Mar 12, 2021
| @@ -23,7 +23,9 @@ | |||
| import struct | |||
|
|
|||
| import unittest | |||
| from unittest.mock import patch | |||
|
|
|||
| if sys.version >= 3.0 | |||
| @@ -76,7 +78,10 @@ def test_encode_record_with_schema(self): | |||
| message = self.ms.encode_record_with_schema(topic, basic, record) | |||
| self.assertMessageIsSame(message, record, schema_id) | |||
|
|
|||
| def test_encode_record_with_schema_sets_writers_cache_once(self): | |||
| def test_encode_r ecord_with_schema_sets_writers_cache_once(self): | |||
There was a problem hiding this comment.
the note specifying not to review this yet was evidently well founded... thanks for the feedback though useful.
| def test_encode_r ecord_with_schema_sets_writers_cache_once(self): | ||
| if sys.version < 3.0 | ||
| # unittest.mock.patch not available | ||
| return |
There was a problem hiding this comment.
this should be a @pytest.skipif()... function attribute
added 2 commits
March 12, 2021 13:11
edenhill
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should fix the travis failure on linux/2.7. given this is the old avro client which is going to be depreciated, i think this hack solution is good enough.
review this only after travis is green. if travis is not green, i will fix