Skip to content

Add document for NewTopic and NewPartitions #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2021
Merged

Add document for NewTopic and NewPartitions #1101

merged 2 commits into from
Apr 22, 2021

Conversation

jliunyu
Copy link
Contributor

@jliunyu jliunyu commented Apr 21, 2021

This is the fix for #855
NewTopic and NewPartitions are not documented, add the documents for these two objects.

@ghost
Copy link

ghost commented Apr 21, 2021

@confluentinc It looks like @jliunyu just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@jliunyu jliunyu requested a review from edenhill April 21, 2021 22:29
@jliunyu
Copy link
Contributor Author

jliunyu commented Apr 21, 2021

Screen shots of my local test
Index
NewTopic1
NewTopic2
NewPartitions1
NewPartitions2

- :ref:`ConsumeError <pyclient_error_consumer>`
- :ref:`ProduceError <pyclient_error_producer>`
- :ref:`SerializationError <serde_error>`
- Errors
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add -Errors instead of an empty line before to make the grouping consistent.

@jliunyu
Copy link
Contributor Author

jliunyu commented Apr 21, 2021

IndexUpdate

@jliunyu jliunyu merged commit 2b8d563 into confluentinc:master Apr 22, 2021
@jliunyu jliunyu deleted the sphinxdoc branch April 26, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy