-
Notifications
You must be signed in to change notification settings - Fork 919
project description in pypi docs #1172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It looks like @Bowrna hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here. Once you've signed reply with Appreciation of efforts, clabot |
[clabot:check] |
It looks like @Bowrna hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here. Once you've signed reply with Appreciation of efforts, clabot |
[clabot:check] |
@confluentinc It looks like @Bowrna just signed our Contributor License Agreement. 👍 Always at your service, clabot |
Issue : #1145 |
@Bowrna I think you can test it using pyroma ( You may also run By the way, thanks a lot for taking over the issue I had submitted and forgot to take care of 😊 |
@rbarrois thank you so much your reply. Sure i will do the steps that you have shared and update in this thread. |
thanks for the PR! i noticed this too - definitely need to get it fixed. side note: relevant people are on leave ATM, there may be a delay getting this merged. |
Thanks @Bowrna, I will merge the PR after the test result is updated. |
@rbarrois i have tested the PR with pyroma like you have suggested and got the below response. Verified the PKG-INFO file inside .tar.gz file in dist folder. It contains description in it.
@mhowlett @jliunyu thank you. if there is anything that i have to fix in this PR, please update in this thread. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit 23b4142. README.md does not pass readme_renderer, for some reason, and this blocks sdist uploads to PyPi.
Added long description into setuptools so that it will be added in pypi description