Skip to content

Removed incorrect infinite timeout value from request timeout doc in Admin APIs #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

pranavrth
Copy link
Member

No description provided.

@pranavrth pranavrth requested a review from a team as a code owner April 17, 2023 10:39
@pranavrth pranavrth force-pushed the dev_infinite-request-timeout branch 2 times, most recently from c0536cb to 5904965 Compare April 17, 2023 11:13
@pranavrth pranavrth force-pushed the dev_infinite-request-timeout branch from 5904965 to 6d4e323 Compare April 17, 2023 11:38
CHANGELOG.md Outdated

v2.1.1 is a maintenance release with the following fixes and enhancements:

* Fix some Admin API documentation stating -1 for infinte timeout incorrectly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling of infinite

Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, just address Milind's comment

@pranavrth pranavrth merged commit eab75fe into master Apr 20, 2023
@pranavrth pranavrth deleted the dev_infinite-request-timeout branch April 20, 2023 21:35
emasab pushed a commit that referenced this pull request Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy