-
Notifications
You must be signed in to change notification settings - Fork 919
Many stability fixes with Handle objects #1591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…LL pointer crashes
This is the recommended way according too the Python docs
46cd593
to
1e8aeac
Compare
) | ||
def test_admin_bad_state(cls, exp_exc, acl_attrs): | ||
# The intent of this test is to test many situations with an empty, | ||
# not configured or incorrect Producer, and see that either an exception of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"incorrect Admin"
|
||
int Handle_check_initialized(Handle *handle, int expectedInitialized) { | ||
if (!expectedInitialized == !handle->rk) { | ||
return 1; // OK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider flipping 1 to 0 and change all places from !Handle_check_initialized
to Handle_check_initialized
) | ||
def test_consumer_bad_state(cls, exp_exc): | ||
# The intent of this test is to test many situations with an empty, | ||
# not configured or incorrect Producer, and see that either an exception of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"incorrect Consumer"
Fixes #1590 which is about the Producer class
Also realized that the same error affected the AdminClient class, so also fixed that.
And then cleaned up the Consumer code to use the same internal API.