Many stability fixes with Handle objects #1591
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LL pointer crashes
This is the recommended way according too the Python docs
46cd593 to
1e8aeac
Compare
|
|
joaoe
commented
Aug 16, 2023
| ) | ||
| def test_admin_bad_state(cls, exp_exc, acl_attrs): | ||
| # The intent of this test is to test many situations with an empty, | ||
| # not configured or incorrect Producer, and see that either an exception of |
joaoe
commented
Aug 16, 2023
|
|
||
| int Handle_check_initialized(Handle *handle, int expectedInitialized) { | ||
| if (!expectedInitialized == !handle->rk) { | ||
| return 1; // OK |
There was a problem hiding this comment.
Consider flipping 1 to 0 and change all places from !Handle_check_initialized to Handle_check_initialized
joaoe
commented
Aug 16, 2023
| ) | ||
| def test_consumer_bad_state(cls, exp_exc): | ||
| # The intent of this test is to test many situations with an empty, | ||
| # not configured or incorrect Producer, and see that either an exception of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1590 which is about the Producer class
Also realized that the same error affected the AdminClient class, so also fixed that.
And then cleaned up the Consumer code to use the same internal API.