Skip to content

Many stability fixes with Handle objects #1591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

joaoe
Copy link

@joaoe joaoe commented Jun 19, 2023

Fixes #1590 which is about the Producer class
Also realized that the same error affected the AdminClient class, so also fixed that.
And then cleaned up the Consumer code to use the same internal API.

@joaoe joaoe requested a review from a team as a code owner June 19, 2023 08:23
@joaoe joaoe force-pushed the producer_crash_fixes branch from 46cd593 to 1e8aeac Compare August 1, 2023 11:00
@cla-assistant
Copy link

cla-assistant bot commented Aug 15, 2023

CLA assistant check
All committers have signed the CLA.

)
def test_admin_bad_state(cls, exp_exc, acl_attrs):
# The intent of this test is to test many situations with an empty,
# not configured or incorrect Producer, and see that either an exception of
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"incorrect Admin"


int Handle_check_initialized(Handle *handle, int expectedInitialized) {
if (!expectedInitialized == !handle->rk) {
return 1; // OK
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider flipping 1 to 0 and change all places from !Handle_check_initialized to Handle_check_initialized

)
def test_consumer_bad_state(cls, exp_exc):
# The intent of this test is to test many situations with an empty,
# not configured or incorrect Producer, and see that either an exception of
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"incorrect Consumer"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash (SEGV) in Producer class
1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy