-
Notifications
You must be signed in to change notification settings - Fork 919
v2.10.1rc1 #1992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.10.1rc1 #1992
Conversation
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Bump the library and tooling version to 2.10.1rc1 across source, packaging, docs, and CI.
- Update C macro and string in confluent_kafka.h
- Bump Python package version in pyproject.toml
- Adjust version references in Dockerfile, Sphinx conf, and Semaphore CI
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
src/confluent_kafka/src/confluent_kafka.h | Bumped CFL_VERSION and CFL_VERSION_STR to 2.10.1rc1 |
pyproject.toml | Updated version to 2.10.1rc1 |
examples/docker/Dockerfile.alpine | Updated LIBRDKAFKA_VERSION to v2.10.1-RC1 |
docs/conf.py | Set Sphinx version to '2.10.1rc1' |
.semaphore/semaphore.yml | Updated CI LIBRDKAFKA_VERSION to v2.10.1-RC1 |
Comments suppressed due to low confidence (2)
examples/docker/Dockerfile.alpine:33
- [nitpick] The prerelease tag uses uppercase "-RC1", while other contexts use lowercase "rc1`. Consider normalizing the case and hyphenation for consistency.
ENV LIBRDKAFKA_VERSION="v2.10.1-RC1"
.semaphore/semaphore.yml:11
- [nitpick] The prerelease tag here uses uppercase "-RC1"; align the tag format with other version strings (lowercase
rc1
) for consistency.
value: v2.10.1-RC1
#define CFL_VERSION 0x020a0000 | ||
#define CFL_VERSION_STR "2.10.0" | ||
#define CFL_VERSION 0x020a0100 | ||
#define CFL_VERSION_STR "2.10.1rc1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are fixing a critical bug according to one of the PRs. Can we change the min librdkafka version as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!.
What
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups