Upgrade cel-python to 0.4.0 and update usage #2015
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the usage of the cel-python library by modifying how context is passed to the evaluator. The change moves context from being passed during activation creation to being passed during evaluation execution.
- Updates CEL evaluator instantiation to pass context during evaluation rather than activation
- Modifies the parameter passing pattern in the cel_field_presence module
| @@ -41,6 +41,6 @@ def macro_has_eval(self, exprlist): | |||
| _has_state.in_has = False | |||
| return result | |||
|
|
|||
| e = Evaluator(ast=self.ast, activation=self.new_activation(context), functions=self.functions) | |||
| value = e.evaluate() | |||
| e = Evaluator(ast=self.ast, activation=self.new_activation(), functions=self.functions) | |||
There was a problem hiding this comment.
The new_activation() method is being called without the context parameter that was previously passed. Verify that this method can handle being called without parameters and that the context will be properly available when passed to evaluate().
| e = Evaluator(ast=self.ast, activation=self.new_activation(), functions=self.functions) | |
| e = Evaluator(ast=self.ast, activation=self.new_activation(context), functions=self.functions) |
Copilot uses AI. Check for mistakes.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Analysis Details0 Issues
Coverage and Duplications
Project ID: confluent-kafka-python |
What
Fix usage of cel-py as some breaking changes were introduced in 0.4.0: cloud-custodian/cel-python#118
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups