Skip to content

Add __version__ to __init__.py #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2017
Merged

Conversation

mrocklin
Copy link
Contributor

@mrocklin mrocklin commented Oct 3, 2017

This is a common convention within Python libraries

>>> import pandas
>>> pandas.__version__
'0.21.0'

@ghost
Copy link

ghost commented Oct 3, 2017

It looks like @mrocklin hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@mrocklin
Copy link
Contributor Author

mrocklin commented Oct 3, 2017

CLA probably won't be signed for a week or so. Legal person is on vacation.

@edenhill
Copy link
Contributor

edenhill commented Oct 4, 2017

Thanks for this!

Could you add a minimal unit test to verify that version is reachable and matches version()?
Preferably here:
https://github.com/confluentinc/confluent-kafka-python/blob/master/tests/test_misc.py#L7

@mrocklin
Copy link
Contributor Author

[clabot:check]

@ghost
Copy link

ghost commented Oct 12, 2017

@confluentinc It looks like @mrocklin just signed our Contributor License Agreement. 👍

Always at your service,

clabot

This is a common convention within Python libraries
@mrocklin
Copy link
Contributor Author

Could you add a minimal unit test to verify that version is reachable and matches version()?

Sure. Done

@mrocklin
Copy link
Contributor Author

There appears to be a build error in Travis-ci. I don't have the background here to diagnose the problem.

@edenhill
Copy link
Contributor

The Travis build looks like an environmental failure, it can be ignored.

@edenhill edenhill merged commit 40fd30c into confluentinc:master Oct 19, 2017
@edenhill
Copy link
Contributor

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy