Unblock 0.11.5 RC packaging #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edenhill
suggested changes
Jun 18, 2018
tools/test-manylinux.sh
Outdated
| pip install confluent_kafka --no-index -f $wheelhouse | ||
|
|
||
| # https://github.com/pypa/pip/issues/5247 |
There was a problem hiding this comment.
Can you write in the comment why the double installs are needed, providing the URL for background info.
|
Thanks @edenhill , updated with a brief description |
edenhill
reviewed
Jun 18, 2018
tools/test-manylinux.sh
Outdated
| @@ -62,6 +62,7 @@ function run_single_in_docker { | |||
|
|
|||
| pip install confluent_kafka --no-index -f $wheelhouse | |||
|
|
|||
| # Pytest relies on a new version of 6; later versions of pip fail to remove older versions gracefully | |||
There was a problem hiding this comment.
"new version of 6"? Do you mean six?
edenhill
reviewed
Jun 19, 2018
tools/test-manylinux.sh
Outdated
| pip install pytest | ||
| pip install pytest --ignore-installed six |
There was a problem hiding this comment.
do we need to install pytest twice?
There was a problem hiding this comment.
how embarrassing...
|
@edenhill , fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couldn't come up with a good solution in time but this should unblock us for the time being