Remove incremental updates #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edenhill
suggested changes
Jul 18, 2018
| :param dict described_configs: For internal use only. | ||
| :param KafkaError error: For internal use only. | ||
|
|
||
| When alter_configs(incremental=False) only set_config is permitted, |
There was a problem hiding this comment.
Don't remove this sentence, it still applies, just remove the incremental stuff.
There was a problem hiding this comment.
The other methods have been removed as part of this change so there is no need to retain this message
confluent_kafka/admin/__init__.py
Outdated
| @@ -478,8 +433,7 @@ def alter_configs(self, resources, **kwargs): | |||
| the provided resources with the new configuration given, | |||
| reverting all other configuration for the resource back | |||
| to their default values. | |||
| Use incremental=True to change the behaviour so that only the | |||
| passed configuration is modified, requires broker version with KIP-248 support. | |||
| If and when KIP-248 is adopted incremental updates will be possible. | |||
There was a problem hiding this comment.
Remove, this will not be part of KIP-248.
|
@edenhill fixed the example I missed |
edenhill
approved these changes
Jul 19, 2018
|
ack both integration tests and manual tests against alter_config and alter_config_delta pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.