Update packaging and bump RC #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edenhill
suggested changes
Jul 19, 2018
tools/RELEASE.md
Outdated
| @@ -5,8 +5,8 @@ when no more blocking issues needs to be fixed a final tag is created | |||
| and the final release is rolled. | |||
|
|
|||
| confluent-kafka-python uses semver versioning and loosely follows | |||
| librdkafka's version, e.g. v0.11.4 for the final release and | |||
| v0.11.4rc3 for the 3rd v0.11.4 release candidate. | |||
| librdkafka's version, e.g. v0.11.5 for the final release and | |||
There was a problem hiding this comment.
no need to update this, these are just examples.
There was a problem hiding this comment.
is there any problem with doing so?
| @@ -57,7 +57,7 @@ | |||
| # The short X.Y version. | |||
| version = '0.11.5' | |||
| # The full version, including alpha/beta/rc tags. | |||
| release = '0.11.5' | |||
| release = '0.11.5rc6' | |||
There was a problem hiding this comment.
this one and setup.py are on rc6 while version() returns v0.11.5. Is this intentional? (if so; fine)
There was a problem hiding this comment.
right so we had a bit of back and forth about include or don't include. Since the comment specifically mentions the tags I decided to keep the RC designation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.