Make group.id required for consumer instantiation(#472) #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93bb0d4 to
6a7da55
Compare
edenhill
suggested changes
Dec 8, 2018
6a7da55 to
91186ad
Compare
edenhill
approved these changes
Dec 10, 2018
| @@ -1629,6 +1629,18 @@ rd_kafka_conf_t *common_conf_setup (rd_kafka_type_t ktype, | |||
| PyDict_Update(confdict, kwargs); | |||
| } | |||
|
|
|||
| if (ktype == RD_KAFKA_CONSUMER) { | |||
| ko = cfl_PyUnistr(_FromString("group.id")); | |||
| if (PyDict_Contains(confdict, ko) != 1) { | |||
There was a problem hiding this comment.
Using PyDict_GetItemString() avoids the extra object ko object creation.
There was a problem hiding this comment.
good point, I see now it returns a borrowed reference; stand-by I'll fix that I just though _Contains felt more propper.
7 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally trashed the original PR.