v1.4.0 openssl, interceptor updates #828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edenhill
suggested changes
Apr 9, 2020
tools/build-openssl.sh
Outdated
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| # NOTE: Keep this updated to make sure we always build the latest | |||
| # version of OpenSSL in the 1.0 release train. | |||
| OPENSSL_VERSION=1.0.2t | |||
| OPENSSL_VERSION_SUFFIX=u | |||
There was a problem hiding this comment.
Why? the suffix is not unique, only in combination with the version. revert this.
edenhill
reviewed
Apr 9, 2020
tools/build-openssl.sh
Outdated
| @@ -23,7 +23,7 @@ if ! grep -q "^VERSION=${OPENSSL_VERSION}$" build-openssl/Makefile ; then | |||
| rm -rf build-openssl | |||
| mkdir -p build-openssl | |||
| pushd build-openssl | |||
| curl -s -l https://www.openssl.org/source/openssl-${OPENSSL_VERSION}.tar.gz | \ | |||
| curl -s -l https://www.openssl.org/source/old/1.0.2/openssl-${OPENSSL_VERSION}.tar.gz | \ | |||
There was a problem hiding this comment.
Lessons learned from librdkafka; do curl -fL <URL>, otherwise it will not fail on 404.
edenhill
approved these changes
Apr 9, 2020
edenhill
reviewed
Apr 9, 2020
tools/build-openssl.sh
Outdated
| @@ -23,7 +23,7 @@ if ! grep -q "^VERSION=${OPENSSL_VERSION}$" build-openssl/Makefile ; then | |||
| rm -rf build-openssl | |||
| mkdir -p build-openssl | |||
| pushd build-openssl | |||
| curl -s -l https://www.openssl.org/source/old/1.0.2/openssl-${OPENSSL_VERSION}.tar.gz | \ | |||
| curl -fl https://www.openssl.org/source/old/1.0.2/openssl-${OPENSSL_VERSION}.tar.gz | \ | |||
edenhill
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.