Skip to content
This repository was archived by the owner on Mar 18, 2019. It is now read-only.

Version 1.1 #10

Merged
merged 11 commits into from
Sep 26, 2016
Merged

Version 1.1 #10

merged 11 commits into from
Sep 26, 2016

Conversation

tomchristie
Copy link
Contributor

@tomchristie tomchristie commented Sep 22, 2016

Still remaining:

def dump(self, document, **kwargs):
def encode(self, document, **options):
if not isinstance(document, Document):
raise ValueError('Expected a `coreapi.Document` instance')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like a TypeError.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tomchristie tomchristie merged commit 5f26e5f into master Sep 26, 2016
@tomchristie tomchristie deleted the version-1-1 branch September 26, 2016 13:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy