Support vertical sharding for parquet queryable #6879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c79456 to
0c64f1b
Compare
|
The fuzz failure seems related. I will spend more time investigating it |
3 tasks
efb09e0 to
bc6e293
Compare
Signed-off-by: yeya24 <benye@amazon.com>
Signed-off-by: yeya24 <benye@amazon.com>
Signed-off-by: yeya24 <benye@amazon.com>
bc6e293 to
a3bc1f0
Compare
Signed-off-by: yeya24 <benye@amazon.com>
Signed-off-by: yeya24 <benye@amazon.com>
Signed-off-by: yeya24 <benye@amazon.com>
|
Merging as correctness test is able to pass if disabling vertical sharding for binary expression without type of queries if parquet is enabled. |
rubywtl
pushed a commit
to rubywtl/cortex
that referenced
this pull request
Jul 28, 2025
rubywtl
pushed a commit
to rubywtl/cortex
that referenced
this pull request
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR implements vertical sharding for parquet queryable by leveraging a series label filtering hook in parquet-common. See prometheus-community/parquet-common#83. Since that PR is still not merged so mark this PR as draft.
Integration test for parquet querier has been updated to enable vertical sharding.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]