Skip to content

Quick edit + Resolved issue #924. #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 7, 2023
Merged

Quick edit + Resolved issue #924. #1082

merged 6 commits into from
May 7, 2023

Conversation

mhayter
Copy link
Contributor

@mhayter mhayter commented Apr 30, 2023

Change minlength(v) to minlen(v) for consistency.
Issue #924 improvement. Will complete after feedback!

@mhayter
Quick edit + partially addressing Issue cp-algorithms#924.
4a11133 
Change minlength(v) to minlen(v) for consistency.
Issue cp-algorithms#924 improvement.  Will complete after feedback!
@github-actions
Copy link
Contributor

Visit the preview URL for this PR (for commit 4a11133):

https://cp-algorithms--preview-1082-xkbiqhxf.web.app

(expires 2023-05-07T11:35:23.728265908Z)

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

Visit the preview URL for this PR (for commit 9075aed):

https://cp-algorithms--preview-1082-xkbiqhxf.web.app

(expires 2023-05-08T01:03:13.906112126Z)

@mhayter
Updated c++ code to work on current style of suffix automaton
da025de 
This is tested on current suffix automaton. Also, made more modular
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

Visit the preview URL for this PR (for commit da025de):

https://cp-algorithms--preview-1082-xkbiqhxf.web.app

(expires 2023-05-08T02:10:25.815254618Z)

@mhayter
complete issue cp-algorithms#924
d8df2dd 
I've now resolved issue cp-algorithms#924. I added new techniques to calculating the total length of different strings.
@mhayter mhayter changed the title Quick edit + partially addressing Issue #924. Quick edit + Resolved issue #924. May 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

Visit the preview URL for this PR (for commit d8df2dd):

https://cp-algorithms--preview-1082-xkbiqhxf.web.app

(expires 2023-05-09T06:02:05.295401074Z)

@mhayter
notation rendering changes
faf8510 
notation changes as preview wasn't working.
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

Visit the preview URL for this PR (for commit faf8510):

https://cp-algorithms--preview-1082-xkbiqhxf.web.app

(expires 2023-05-09T06:18:03.626668782Z)

jakobkogler
jakobkogler approved these changes May 7, 2023
View reviewed changes
Copy link
Member

@jakobkogler jakobkogler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks great. Thanks for the contribution.

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2023

Visit the preview URL for this PR (for commit af01de8):

https://cp-algorithms--preview-1082-xkbiqhxf.web.app

(expires 2023-05-14T09:57:09.141445999Z)

@jakobkogler jakobkogler merged commit e291a7e into cp-algorithms:master May 7, 2023
@jakobkogler jakobkogler mentioned this pull request May 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobkogler jakobkogler jakobkogler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhayter @jakobkogler
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy