Skip to content

Resolving issue #915 #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 26, 2023
Merged

Resolving issue #915 #1196

merged 2 commits into from
Nov 26, 2023

Conversation

mhayter
Copy link
Contributor

@mhayter mhayter commented Nov 21, 2023

Attempt to resolve issue #915. Added additional explanation on how to use. Wondered if making arguments than don't change constant makes more sense? Formatted code more similarly to previous versions of segment tree.

Attempt to resolve issue cp-algorithms#915. Added additional explanation on how to use. Wondered if making arguments than don't change constant makes more sense? Formatted code more similarly to previous versions of segment tree.
Copy link
Contributor

Visit the preview URL for this PR (for commit e4b572c):

https://cp-algorithms--preview-1196-sgvmjvay.web.app

(expires 2023-11-28T08:21:48.353533337Z)

@mhayter
Copy link
Contributor Author

mhayter commented Nov 21, 2023

P.S. I had tested an implementation of this on CSES Hotel Queries (https://cses.fi/problemset/task/1143). Interestingly, though, this code is named but doesn't seem to be tested in the test file.

Copy link
Member

@jakobkogler jakobkogler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

I've changed the variable greater_than with x, since the description further up uses x.

for a given value $x$ ... find the smallest $i$..., such that $a[i]$ is greater than $x$.

@jakobkogler jakobkogler merged commit 289e733 into cp-algorithms:master Nov 26, 2023
Copy link
Contributor

Visit the preview URL for this PR (for commit 0b8bc8d):

https://cp-algorithms--preview-1196-sgvmjvay.web.app

(expires 2023-12-03T14:59:53.805606103Z)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy