Skip to content

Remove disputed linear union-find claims for now #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Remove disputed linear union-find claims for now #984

merged 1 commit into from
Jan 5, 2023

Conversation

jxu
Copy link
Contributor

@jxu jxu commented Dec 26, 2022

Resolves #979

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (for commit 6d88735):

https://cp-algorithms--preview-984-3wg8ogmf.web.app

(expires 2023-01-02T16:23:42.261625028Z)

@adamant-pwn
Copy link
Member

Thanks! Generally, I'm not a fan of just removing information. There were such articles at least, as I understand. I would instead try to amend the wording to "there were articles" instead of "there are articles" and then tell what happened after that, and why their point no longer stands. As OP of #979 says, the first article was retracted, and the second one is not peer-reviewed, right?

@reverofevil
Copy link

Even though sometimes it's important to mention a history of wrong or negative results, I don't think it's a good fit for an educational resource. Not everyone has sufficient exposure to scientific method to properly label this statement as mostly irrelevant to anything done with DSU in practice. This statement is highly misleading, and should be dropped.

@jxu
Copy link
Contributor Author

jxu commented Dec 28, 2022

Even though sometimes it's important to mention a history of wrong or negative results, I don't think it's a good fit for an educational resource. Not everyone has sufficient exposure to scientific method to properly label this statement as mostly irrelevant to anything done with DSU in practice. This statement is highly misleading, and should be dropped.

I would be inclined to keep the negative results if they are mentioned in other surveys or textbooks on the problem. I can't adequately judge whether either of these papers had any impact at all.

@jxu jxu closed this by deleting the head repository Jan 1, 2023
@jxu jxu reopened this Jan 4, 2023
@jxu
Copy link
Contributor Author

jxu commented Jan 4, 2023

Accidentally closed the PR before when cleaning up my repos

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

Visit the preview URL for this PR (for commit 6d88735):

https://cp-algorithms--preview-984-jktwvpg6.web.app

(expires 2023-01-11T04:31:40.117995038Z)

@jakobkogler
Copy link
Member

The accepted time complexity seems to be $O(\alpha(n))$.
So I also believe, that deleting the sentence about possible improvements is the best.

The first paper was clearly wrong (as it was deleted by the author).
And I also believe that the second paper (https://www.researchgate.net/publication/235708752_A_simpler_proof_of_the_average_case_complexity_of_union-find_with_path_compression) is wrong. I seems like they forgot that the height of tree's will grow again after union operations (although I haven't studied the problem and the paper in detail).

@jakobkogler jakobkogler merged commit 89c563d into cp-algorithms:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About Zhang's paper "Union-Find Problem Is Linear"
4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy