Skip to content

Remove readability/fn_size error throw #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2024
Merged

Remove readability/fn_size error throw #287

merged 1 commit into from
Sep 7, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Sep 6, 2024

@aduh95 aduh95 mentioned this pull request Sep 6, 2024
Merged
@matyalatte
Copy link

I agree that fn_size should be disabled, as the style guide says "no hard limit is placed on function length."
https://google.github.io/styleguide/cppguide.html#Write_Short_Functions

But I think you can just add -readability/fn_size to _DEFAULT_FILTERS. No need to remove anything.
https://github.com/cpplint/cpplint/blob/34a534a786729408fc5d4ed91d28eeb0b6d1e6e1/cpplint.py#L414

@aduh95 aduh95 force-pushed the fix-readability/fn_size branch from 34a534a to 73f2546 Compare September 6, 2024 23:07
@aduh95
Copy link
Contributor Author

aduh95 commented Sep 6, 2024

@matyalatte you're right, that's a much better and simpler fix 👍

aaronliu0130
aaronliu0130 approved these changes Sep 7, 2024
View reviewed changes
Copy link
Member

@aaronliu0130 aaronliu0130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess those interested could manually reenable it.

@aaronliu0130 aaronliu0130 changed the title fix: remove readability/fn_size error throw Remove readability/fn_size error throw Sep 7, 2024
@aaronliu0130 aaronliu0130 merged commit 820df48 into cpplint:develop Sep 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronliu0130 aaronliu0130 aaronliu0130 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @matyalatte @aaronliu0130 @RafaelGSS
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy