Don't err on non-const references by default #305
Conversation
|
Will fix test errors |
|
Please rebase. |
CHANGELOG.rst
Outdated
| @@ -10,6 +10,7 @@ Yet another overdue... hotfix. Sorry this took so long. | |||
| * The false positive for indented function parameters in namespaces was eradicated. (https://github.com/cpplint/cpplint/pull/304) | |||
| * build/include-what-you-use now recognizes c-style headers, such as <stdio.h> for symbols from <cstdio>. (https://github.com/cpplint/cpplint/pull/319) | |||
| * The warning on non-const references (runtime/references) is now disabled by default pursuant to the May 2020 Google style guide update. (https://github.com/cpplint/cpplint/pull/305) | |||
| * Ruff was ran on the project to improve performance and reader comprehension thanks to @cclauss. | |||
There was a problem hiding this comment.
- That would be for a different PR, maybe the bump release date one.
- There's way more changes to improve performance than comprehensions and I don't see the need to single this out. Plus there are indeed many readability linter changes
|
pls review |
|
Please rebase your pull requests to resolve git conflicts with https://github.com/cpplint/cpplint/releases v2.0.1. |
|
Sure. I wonder why you decided to release instead of merge, though, especially the other namespace indentation fix still pending; that one's vital (though less vital than the original fix) since codebases that are quality enough to use namespaces can be expected to use member initializer lists when suitable, and classes with simple member value assignments in the constructor are quite common. |
|
Pull requests which remove tests are difficult to approve. Now that release capabilities are proven, we can release whenever there are useful changes. |
|
Well, the namespace indentation thing didn't remove any tests either. And it's extremely useful. |
| @@ -3,7 +3,7 @@ src/* | |||
| 4 | |||
| Done processing src/pptable.cpp | |||
| Done processing src/pptable.h | |||
| Total errors found: 685 | |||
| Total errors found: 675 | |||
There was a problem hiding this comment.
Are we finding fewer expected errors?
| @@ -3,22 +3,17 @@ | |||
| 4 | |||
| Done processing src/sillycode.cpp | |||
| Done processing src/sillycode.w | |||
| Total errors found: 26 | |||
| Total errors found: 21 | |||
There was a problem hiding this comment.
Are we finding fewer expected errors?
| Category 'runtime' errors found: 12 | ||
| Total errors found: 22 | ||
| Category 'runtime' errors found: 7 | ||
| Total errors found: 17 |
There was a problem hiding this comment.
Are we finding fewer expected errors?
| @@ -2,7 +2,7 @@ | |||
| 1 | |||
| 3 | |||
| Done processing src/sillycode.cpp | |||
| Total errors found: 123 | |||
| Total errors found: 118 | |||
There was a problem hiding this comment.
Are we finding fewer expected errors?
| @@ -3,7 +3,7 @@ src/* | |||
| 4 | |||
| Done processing src/sillycode.cpp | |||
| Done processing src/sillycode.w | |||
| Total errors found: 126 | |||
| Total errors found: 121 | |||
There was a problem hiding this comment.
Are we finding fewer expected errors?
|
Yes, and this PR is not the namespace indentation thing I was talking about. |
|
Please resolve the git conflict in |
As a side note, we should probably consider not running filtered checks sometime in the future.
Please squash on merge with GitHub's shiny button.