IWYU: treat stdio.h the same way as cstdio

cpplint · aaronliu0130 · Mar 4, 2025 · Feb 1, 2025 · Feb 1, 2025 · Feb 1, 2025
commit cdaa9506887d15a96d34d68884f914ff1f14decb
diff --git a/cpplint.py b/cpplint.py
@@ -6220,12 +6220,14 @@ def CheckForIncludeWhatYouUse(filename, clean_lines, include_state, error,
                        for item in sublist])
 
   # All the lines have been processed, report the errors found.
-  for required_header_unstripped in sorted(required, key=required.__getitem__):
-    template = required[required_header_unstripped][1]
-    if required_header_unstripped.strip('<>"') not in include_dict:
-      error(filename, required[required_header_unstripped][0],
+  for header in sorted(required, key=required.__getitem__):
+    template = required[header][1]
+    if (header.strip('<>"') not in include_dict
+            and not (header.strip('<>"')[0] == 'c'
+                     and (header.strip('<>"')[1:] + '.h') in include_dict)):
+      error(filename, required[header][0],
             'build/include_what_you_use', 4,
-            'Add #include ' + required_header_unstripped + ' for ' + template)
+            'Add #include ' + header + ' for ' + template)
 
 
 _RE_PATTERN_EXPLICIT_MAKEPAIR = re.compile(r'\bmake_pair\s*<')

diff --git a/cpplint_unittest.py b/cpplint_unittest.py
@@ -1122,6 +1122,9 @@ def testIncludeWhatYouUse(self):
     self.TestIncludeWhatYouUse(
         'printf("hello world");',
         'Add #include <cstdio> for printf  [build/include_what_you_use] [4]')
+    self.TestIncludeWhatYouUse(
+      """#include <stdio.h>
+      printf("hello world");""", '')  # Avoid false positives w/ c-style include
     self.TestIncludeWhatYouUse(
         'void a(const string &foobar);',
         'Add #include <string> for string  [build/include_what_you_use] [4]')