Ruff rules PL for Pylint #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
commented
Mar 7, 2025
| @@ -6814,7 +6811,7 @@ def ParseArguments(args): | |||
| output_format = val | |||
| elif opt == '--quiet': | |||
| quiet = True | |||
| elif opt == '--verbose' or opt == '--v': | |||
| elif opt in {'--verbose', '--v'}: | |||
There was a problem hiding this comment.
Should the second item be --v or just -v?
There was a problem hiding this comment.
How about we include both?
Or we should check whether --v can be removed, as that is non-standard and hopefully not in use
There was a problem hiding this comment.
I'd prefer replacing --v, but I have no idea how we'll check if people use --v.
There was a problem hiding this comment.
Discussion moved because this would be a breaking change as in that current production usage may break.
0f82b45 to
01e6e78
Compare
01e6e78 to
dac8fda
Compare
|
Reviews please. |
aaronliu0130
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ruff rules PL for Pylint: https://docs.astral.sh/ruff/rules/#pylint-pl
%
ruff check --select=PL%
ruff check --select=PLR0 --preview