ruff rule N805: First argument of a method should be named self
#339
Conversation
f8eb245 to
5c6617c
Compare
There was a problem hiding this comment.
- I forgot why I made it delete a parameter...
- Are you sure that's true?
The names of the test cases generated by @parameterized.expand can be customized using the name_func keyword argument. The value should be a function which accepts three arguments: testcase_func, param_num, and params, and it should return the name of the test case. testcase_func will be the function to be tested, param_num will be the index of the test case parameters in the list of parameters, and param (an instance of param) will be the parameters which will be used.
In my testing, the "fun" parameter pre-rename was indeed a string, and making the signature (self, fun, _, x) did not produce the results expected and I think even threw errors.
This is a method, not a function. |
|
Will rebase. (It said 3 files left unchanged for me though...) |
333e054 to
f1a03ef
Compare
f1a03ef to
a9f59ef
Compare
|
Had to reword 79febcb because apparently commit msg lines starting with "#" are not ignored... |
This code is not deleting the function (method) but is instead deleting the class!
https://docs.astral.sh/ruff/rules/invalid-first-argument-name-for-method