Mypy: static type checker for Python #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
708f5a6 to
5d23163
Compare
|
No problem merging as-is. I wonder what’s our standard for what to put in pre-commit vs tox, though. Like ruff format is obviously pre-commit but pylint, flake8, and ruff check not so much. |
|
pre-commit is for really fast (subsecond?) stuff and tox is for slower stuff. This aligns with pre-commit's recommendations. For runtimes, try: I think we can lose flake8 at this point. |
aaronliu0130
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://mypy-lang.org