Fix test refactoring #350
Merged
Fix test refactoring #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace self.fail()s Fix edge case of verifying categories when running pytest on a specific function through module notation Fix indented parameter test Make _Seen_Error_Categories a set Make clitest setup and teardown conform to naming
cclauss
reviewed
Mar 23, 2025
cpplint_unittest.py
Outdated
| for line in error_collector.ResultList(): | ||
| if line.find("build/header_guard") != -1: | ||
| self.fail("Unexpected error: %s" % line) | ||
| assert not any("build/header_guard" in line for line in error_collector.ResultList()) |
There was a problem hiding this comment.
Although ruff rule SIM110 recommends the use of any() because it is much easier to read and understand, it may make pytest results harder to understand because it may not show the text on those lines that fail.
Also, (I learned the hard way) that any() is actually slower than the long form that it replaces.
There was a problem hiding this comment.
Apparently it is faster than the form it replaces if you use it like any(True for line in error_collector.ResultList() if "build/header_guard" in line) instead, but you're right that it doesn't show the line.
cclauss
approved these changes
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace self.fail()s
Fix edge case of verifying categories when running pytest on a specific function through module notation Fix indented parameter test
Make _Seen_Error_Categories a set
Make clitest setup and teardown conform to naming