Skip to content

feat: update Get-RandomPassword to use Set-Clipboard #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

feat: update Get-RandomPassword to use Set-Clipboard #42

merged 1 commit into from
Apr 10, 2025

Conversation

danstis
Copy link
Owner

@danstis danstis commented Apr 10, 2025 •
edited by sophie-syntax bot
Loading

User description

Fixes #41

PR Type

  • Enhancement

Description

  • Replaced Clip with Set-Clipboard for clipboard operation.

  • Ensured no trailing newline is added when copying password.

Changes walkthrough 📝

Relevant files
Enhancement
Get-RandomPassword.ps1
Update clipboard command in Get-RandomPassword function   

functions/Get-RandomPassword.ps1

  • Changed clipboard command from Clip to Set-Clipboard.
  • Retained password output behavior post clipboard copy.
    		• +1/-1     
    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
    •

    @sophie-syntax sophie-syntax bot changed the title feat: update Get Password function to use Set-Clipboard rather than clip feat: update Get-RandomPassword to use Set-Clipboard Apr 10, 2025
    @sophie-syntax Sophie Syntax
    Copy link

    sophie-syntax bot commented Apr 10, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis 🔶

    41 - Partially compliant

    Compliant requirements:

    • Replaced "| clip" with "Set-Clipboard"
    • Clipboard output is modified to exclude a trailing newline

    Non-compliant requirements:

    Requires further human verification:

    • Verify that "Set-Clipboard" behaves consistently across different environments
    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @sophie-syntax Sophie Syntax
    Copy link

    sophie-syntax bot commented Apr 10, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @danstis danstis merged commit 83cce14 into master Apr 10, 2025
    4 checks passed
    @danstis danstis deleted the danstis/issue41 branch April 10, 2025 04:56
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers
    No reviews
    Assignees
    No one assigned
    Labels
    Review effort 1/5
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Update Get Password function to use Set-Clipboard rather than clip
    1 participant
    @danstis
    pFad - Phonifier reborn

    Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

    Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


    Alternative Proxies:

    Alternative Proxy

    pFad Proxy

    pFad v3 Proxy

    pFad v4 Proxy