Skip to content

Remove duplicate Content-type header #4026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025
Merged

Conversation

webflo
Copy link
Contributor

@webflo webflo commented Feb 27, 2025

The Grafana plugin is broken, because the generated request has two http header (Content-type and Content-Type). The later one, it the correct header and its added by \Deployer\Utility\Httpie::jsonBody. The Grafana API returns "Bad request".

  • Bug fix #…?

  • New feature?

  • BC breaks?

  • Tests added?

  • Docs added?

    Please, regenerate docs by running next command:
    $ php bin/docgen
    

The Grafana plugin is broken, because the generated request has two http header (Content-type and Content-Type). The later one, it the correct header and its added by \Deployer\Utility\Httpie::jsonBody
@blankse
Copy link

blankse commented Apr 2, 2025

@webflo I think the target branch should be 7.x because it is a bug.

@webflo
Copy link
Contributor Author

webflo commented Apr 2, 2025

#4049 created for 7.x Thanks!

@antonmedv antonmedv merged commit 808d22b into deployphp:master Apr 2, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy