Specify that the additional partial member field is optional #7678
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For what it's worth, the member info is not present for users who got banned or kicked or just left so the assumption that it's required wouldn't have made sense to begin with. |
|
@Rapptz I mean, when I was trying to statically type the entirety of the Discord REST API, I wasn't always thinking about the logic of why certain options are provided / not provided unless its relevant to the type. I was just writing down the types that the docs say :/ This definitely would've been helpful to have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across a parsing error in
zigcord(https://codeberg.org/lipfang/zigcord) which had incorrectly assumed that thememberfield withinmentionsarray of the Message Create gateway event was required.Not quite sure if this falls under "subjective wording changes" in the contributing guidelines, but I feel that the statement is incorrect since it seems to assert that the
memberfield is required.The following message is an example of a message which contains a
mentionsproperty that contains users which don't havememberfields. It is a message from the Wordle Discord Bot with a summary of those who have played wordle today, mentioning many guild members.https://gist.github.com/lipfangmoe/6130b9a42a4396ddb4f62ec91c0a6527